fix(accordion): align styling with Figma + fill Storybook/test gaps#223
Merged
Conversation
|
📚 Storybook preview: https://pr-223-propel-storybook.vamsi-906.workers.dev |
- Added `Disabled` story to demonstrate the behavior of disabled accordion items, ensuring proper interaction and accessibility. - Introduced `Controlled` story to showcase how external state management can control the accordion's open panels, including "Expand all" and "Collapse all" buttons. - Updated existing stories to improve clarity and functionality, ensuring consistent user experience across different accordion states. - Enhanced documentation and comments for better understanding of the accordion's behavior in various scenarios.
codingwolf-at
changed the title
…endering - Changed accordion panel variant class from "text-13 text-secondary" to "text-13 font-regular text-secondary" to enhance text appearance and maintain consistency across accordion components.
- Eliminated the `AccordionTriggerIcon` component to simplify the structure of the `AccordionTrigger`. - Updated the `AccordionTrigger` to directly render the icon, enhancing flexibility and reducing unnecessary complexity. - Adjusted related stories and variants to reflect the removal of the icon component, ensuring consistent behavior across the accordion elements.
lifeiscontent
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bring the Accordion in line with its Figma spec and close missing Storybook/test coverage.
Styling fixes (Figma parity)
data-disabled/aria-disabled(item-level disable never sets nativedisabled, so:disabledalone never matched)Stories & tests
data-disabled/aria-disabled, click is a no-op, sibling still toggles)value/onValueChangestory with external Expand/Collapse-all controls + testMultipleItemsInteractionType of Change
Screenshots and Media (if applicable)
NA
Test Scenarios
vp checkcleanvp testgreen (793 tests)References
NA